-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cookidoo integration #129800
base: dev
Are you sure you want to change the base?
Add Cookidoo integration #129800
Conversation
translation_key="setup_request_exception", | ||
) from e | ||
except CookidooAuthException as e: | ||
raise ConfigEntryAuthFailed( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will trigger the reauth, use ConfigEntryNotReady
while there isn't a reauth flow implemented
raise ConfigEntryAuthFailed( | |
raise ConfigEntryNotReady( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently there is a reauth implemented, depends on the decision on #129800 (comment)
errors=errors, | ||
) | ||
|
||
async def async_step_reauth( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reauth and reconfigure flows are usually not accepted in the first PR, they should be added in follow-up PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, sad. They are the same as in the bring integration and essential just copy paste.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will leave it in until home assistant tells me to remove it for a first PR :)
Questions remaining?
|
reauth_entry: CookidooConfigEntry | ||
reconfigure_entry: CookidooConfigEntry | ||
AUTH_DATA_SCHEMA: dict | ||
LOCALIZATION_DATA_SCHEMA: dict | ||
country_codes: list[str] | ||
languages: list[str] | ||
localizations: list[CookidooLocalizationConfig] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move those to instance instead of class vars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why and how? In did copy the bring
setup which does have it like that? @zweckj
Ugh, I can't unread it as cookie dough now |
haha (oups, commented and closed accidentally) |
Proposed change
Add an integration for Cookidoo. We start by adding the shopping list, which is actually two lists in one. There is a list for all ingredients which are related to recipe one wants to cook and one for additional items. The additional items behaves as one would expect from a todo list, but the ingredients list can only be ticked off and not add/rename/delete is available, as the ingredients are controlled by the parent-recipe.
Brands: home-assistant/brands#6037
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: