-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing translations and descriptions for notification fields in UI #132676
base: dev
Are you sure you want to change the base?
Add missing translations and descriptions for notification fields in UI #132676
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
"name": "Notifications 'Send a notification with html5'", | ||
"description": "Sends a notification message using the html5 service.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd go w/ HTML5 as display term, hm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! You're right—'HTML5' as a display term is more consistent with standard capitalization and naming conventions. I'll update this to reflect that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
Can we merge it? |
I don't have the write access so you have to wait for someone in charge. 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The notify platform already has a generic message "Send a notification with {self._service_name}"
which is also used for the html5 component. Should that be translated instead of adding strings specifically for html5?
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yazan-abdalrahman did you miss my comment in #132676 (review) ?
Hi, I saw the comment, and I wrote a new solution, so you can review it? |
fix description message "remove 2"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new implementation does not provide a way for the descriptions to be translated. Is that expected?
Also, it would be great if we could have a way to translate the Send a notification via {target_name}"
sentence in a generic way (instead of translating it for specific integrations only)
Done. Can you review it? |
Proposed change
This PR fixes missing translations in the HTML5 Push Notifications UI action. It adds the action name, description, and translatable fields such as message, title, and target.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: