Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add azure_storage as backup agent #134085

Merged
merged 72 commits into from
Feb 24, 2025
Merged

Conversation

zweckj
Copy link
Member

@zweckj zweckj commented Dec 27, 2024

Breaking change

Proposed change

Add azure_storage integration to allow backups to Azure blob storage.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@zweckj zweckj changed the title Add azure_storage integration Add azure_storage as backup agent Dec 27, 2024
@zweckj zweckj marked this pull request as ready for review December 27, 2024 19:48
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@MartinHjelmare could you take a look too?

@emontnemery emontnemery added the second-opinion-wanted Add this label when a reviewer needs a second opinion from another member. label Feb 24, 2025
@zweckj zweckj added this to the 2025.3.0b0 milestone Feb 24, 2025
@home-assistant home-assistant bot marked this pull request as draft February 24, 2025 16:52
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@MartinHjelmare MartinHjelmare removed the second-opinion-wanted Add this label when a reviewer needs a second opinion from another member. label Feb 24, 2025
@zweckj zweckj marked this pull request as ready for review February 24, 2025 17:23
@MartinHjelmare
Copy link
Member

MartinHjelmare commented Feb 24, 2025

The error message in the test assertion needs to be updated.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zweckj
Copy link
Member Author

zweckj commented Feb 24, 2025

Thanks!

thanks Martin!

@zweckj zweckj merged commit dc92e91 into home-assistant:dev Feb 24, 2025
42 checks passed
@zweckj zweckj deleted the azure-storage/init branch February 24, 2025 19:59
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants