Skip to content

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Feb 21, 2025

Proposed change

The table rebuild to fix the foreign key constraint was added in #120779 but the schema version was not bumped so we need to make sure any database that was created with schema 43 or older still has the migration run as otherwise they will not be able to purge the database with SQLite since each delete in the events table will due a full table scan of the states table to look for a foreign key that is not there

Note that everything works as expected with the migration, but the schema version was set too low so it simply didn't run. The only functional change here is the constant value used to run the migration for databases that were created with schema <= 43 and instead of schema < 28

fixes #138818 fixes #138649 fixes #137651

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@bdraco bdraco requested a review from a team as a code owner February 21, 2025 20:26
@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of recorder can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign recorder Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

The table rebuild to fix the foreign key constraint was added
in #120779 but the
schema version was not bumped so we need to make sure
any database that was created with schema 43 or older
still has the migration run as otherwise they will not
be able to purge the database with SQLite since each
delete in the events table will due a full table scan
of the states table to look for a foreign key that is
not there

fixes #138818
@bdraco bdraco added this to the 2025.3.0b0 milestone Feb 21, 2025
@bdraco bdraco changed the title Fix minimum version to run event_id_post_migration Fix minimum schema version to run event_id_post_migration Feb 21, 2025
@bdraco bdraco marked this pull request as draft February 22, 2025 01:14
@bdraco
Copy link
Member Author

bdraco commented Feb 22, 2025

Got distracted with esphome/esphome#8297 need to finish fixing the tests

@bdraco bdraco marked this pull request as ready for review February 22, 2025 03:15
@balloob balloob merged commit 93b01a3 into dev Feb 22, 2025
46 checks passed
@balloob balloob deleted the event_id_post_migration branch February 22, 2025 20:39
@bdraco
Copy link
Member Author

bdraco commented Feb 22, 2025

Thanks

@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.