Skip to content

Conversation

@mib1185
Copy link
Member

@mib1185 mib1185 commented Feb 23, 2025

Proposed change

This disables the file station api on nas with dsm < 6.0.

As per the official FileStation api docs the FileStation api is available since 6.0. There was a predecessor called FileBrowser on dsm 5.2, which is partially compatible with the FileStation api, but not completely (see #137522 (comment)). So the feature isn't usable at all at the moment, and therefore gets disabled on older dsm versions.

Unfortunately Synology removed everything from its support pages around old and unsupported DSM versions because of licence changes, so I've no possibility to download an old vDSM 5.2 image anymore to reverse-engineer the FileBrowser api.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@mib1185 mib1185 added this to the 2025.3.0b0 milestone Feb 23, 2025
@mib1185 mib1185 requested a review from Quentame as a code owner February 23, 2025 11:00
@home-assistant home-assistant bot added bugfix cla-signed integration: synology_dsm Synology DSM small-pr PRs with less than 30 lines. labels Feb 23, 2025
@home-assistant
Copy link

Hey there @hacf-fr, @Quentame, mind taking a look at this pull request as it has been labeled with an integration (synology_dsm) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of synology_dsm can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign synology_dsm Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@mib1185 mib1185 merged commit 4ca3963 into dev Feb 23, 2025
32 checks passed
@mib1185 mib1185 deleted the synology_dsm/backup-agent-requires-dsm-6.0 branch February 23, 2025 12:27
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants