-
-
Notifications
You must be signed in to change notification settings - Fork 36.6k
Add backup helper #139199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backup helper #139199
Conversation
|
We still want to load it relatively early. Let's create a new stage for backup and hassio right after recorder. Or maybe after debugger. |
796f603 to
5aa579d
Compare
|
Why do we want to load backup and hassio early? |
|
Because frontend makes that call to the backup WS API, and we probably want that to return as fast as possible. |
|
Unless we don't care about that. If we don't, then we should instead re-add |
|
Probably would make sense to "restore" the previous execution order unless we are really sure there are no other dependencies? |
Oh, right, it was removed in #137668. |
|
You'll probably also need to add |
|
Tested on production ✅ |
Proposed change
Add backup helper which contains:
This allows us to remove
backupfromafter_dependenciesoffrontendandonboardingThe root issue is that frontend has no way to wait for core integrations to be ready, and we generally work around that by adding integrations which has APIs frontend needs to frontend's after_dependencies or dependencies. However, that has unwanted consequences because frontend is set up very early.
Going forward, we should add a way for frontend to check which integrations will be setup and a way for it to wait for an integration to set up.
The backup helper added by this PR can then be removed.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: