Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full test coverage for Comelit humidifier platform #141852

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

chemelli74
Copy link
Contributor

@chemelli74 chemelli74 commented Mar 30, 2025

Proposed change

Add tests for Comelit humidifier platform

Needs: #141854

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link
Contributor

@sstallion sstallion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sstallion sstallion mentioned this pull request Apr 1, 2025
19 tasks
@NoRi2909
Copy link
Contributor

NoRi2909 commented Apr 2, 2025

Just saw

entity::humidifier::humidifier::name
entity::humidifier::dehumidifier::name

land in Lokalise for translations. You might also be able to replace both with references to these:

"[%key:component::humidifier::entity_component::humidifier::name%]"
"[%key:component::humidifier::entity_component::dehumidifier::name%]"

Then the translations will be automatically covered for most languages.
Perhaps something to be integrated along with the tests.

@chemelli74 chemelli74 marked this pull request as ready for review April 2, 2025 18:27
@chemelli74
Copy link
Contributor Author

Just saw
[...]
Then the translations will be automatically covered for most languages. Perhaps something to be integrated along with the tests.

This PR is only about tests (after rebase 😉 ).
I think it's better to open a new PR for the string changes.

@chemelli74 chemelli74 requested a review from joostlek April 7, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants