-
-
Notifications
You must be signed in to change notification settings - Fork 34.6k
Matter Semantic Tag Namespaces #147339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Matter Semantic Tag Namespaces #147339
Conversation
Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
What do you think of this proposal? |
I'm working on a similar update that may be of interest to you. The approach I'm taking starts with a semantic tag-to-text translator for all semantic tags semantic_tags.py I was planning to then add this into the labeling code that I've proposed in PR 149524 In that PR, a labeling improvement is you can specify where Matter labels are placed by setting "label_location = "name", "after", or "ignore", in the discovery schema for an entity, and you can also override the default search labels set and specify a custom list of labels to search on a per-entity basis. For tags, I was going to do the same thing, but allow you to specify a custom list of tags in each entities discovery scheme ("use_tag_namespaces = { 0x12, 0x08 }). I'm waiting for PR 149525 to be done, then will add tags as a small PR onto that. Anyway, consider if the approach I'm planning makes sense to you and would satisfy your use case. I think the approach I'm planning would "overwrite" your changes, so I'm hoping to work with you on a unified proposal that would address all use cases. |
@@ -1959,7 +1959,7 @@ | |||
'disabled_by': None, | |||
'domain': 'select', | |||
'entity_category': None, | |||
'entity_id': 'select.mock_oven_temperature_level', | |||
'entity_id': 'select.mock_oven_temperature_level_left', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mock oven temperature left?
Are we sure this is what we want? I am also wondering how often this happens, maybe translations can be better here so people can translate it like Left oven temperature level
or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, some cases are more difficult to manage. This is the case, for example, with a stove with several compartments.
I need to find a solution to better manage position tags. I am interested in suggestions for improvement.
'original_name': 'Temperature level (Left)',
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Proposed change
Use Matter
TagList
attribute and namespaces to generate postfix name only if present.Some device like Aqara Climate Sensor W100 or Hue Bridge has TagList attribute in Descriptor Cluster.
This allow the controller to rename entities using the location of the buttons on a multi-button switch device.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: