-
-
Notifications
You must be signed in to change notification settings - Fork 34.6k
Matter Dead front behavior #150113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Matter Dead front behavior #150113
Conversation
Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
entity_description=MatterNumericSwitchEntityDescription( | ||
key="MatterDeadFrontToggle", | ||
device_class=SwitchDeviceClass.SWITCH, | ||
translation_key="dead_front", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "dead front" mean and why should we add a switch entity for it? The PR description doesn't explain this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On household appliances, there is a button that turns the appliance's control panel on or off.
The Matter specifications allow this to be replicated. They call this “dead front” behavior.
This switch is defined in the specifications and allows this behavior to be enabled or disabled:
- Off command of the On/Off cluster SHALL move the device into the "dead front" state
- On command of the On/Off cluster SHALL bring the device out of the "dead front" state
If this behavior is enabled, the device will not respond to start/stop/pause requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mabe I can rename it to 'Lock control panel'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's a better name.
It should have entity category CONFIG
, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed by last commit
Here are some additional explanations about this feature:
|
My fear with this entity is that's a bit vague what exactly is locked and what isn't locked on the device, reading the specification. I think it may be hard for users to understand how and when they can use the entity. I'm not completely convinced that we should add it. |
I suggest we take this topic up for discussion in an appropriate place. We're about to move issue trackers etc for Matter. I'll check with Marcel where he thinks we should hold the discussion. |
The problem is that the switch is already displayed in the interface, but as a PowerSwitch. |
I think we should first decide if we want to expose this at all. |
Proposed change
Add support for Matter Dead front behavior:
On household appliances, there is a button that turns the appliance's control panel on or off.
The Matter specifications allow this to be replicated. They call this “dead front” behavior.
This switch is defined in the specifications and allows this behavior to be enabled or disabled:
If this behavior is enabled, the device will not respond to start/stop/pause requests.
Type of change
Additional information
Matter specs
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: