Skip to content

Conversation

@MindFreeze
Copy link
Member

@MindFreeze MindFreeze commented Dec 18, 2025

Proposed change

Continued from #25668

UI is the same but the technical implementation is new.

The only reliable link we have between the editor and the preview is the config. So I added a callback to it that the card can use to send data back.
It's added with a symbol so it is completely ignored during serialization. deepEqual also ignored symbols so I added a new option for them.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@MindFreeze MindFreeze marked this pull request as ready for review December 18, 2025 07:17
@karwosts
Copy link
Member

This is kinda broken for conditional elements.

When editing the conditional itself, it instructs you to click, but clicking adds the style to the conditional which isn't supported, and leave you with a config error and broken UI.

When editing the child element of a conditional, it still attach the click style to the parent conditional, and not the child, causing same problem.

Otherwise very cool 😎

@MindFreeze
Copy link
Member Author

MindFreeze commented Dec 18, 2025

Nice catch. I just excluded conditional elements for now. We can deal with them later. Also fixed an existing error with the stub config for conditionals

@silamon silamon added the Noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Dec 22, 2025
@bramkragten bramkragten added the Needs UX Pull requests requiring a review from the Home Assistant design team label Dec 23, 2025
@MindFreeze MindFreeze removed the Needs UX Pull requests requiring a review from the Home Assistant design team label Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Finish picture elements position PR (#25668)

5 participants