Add "show not installable option" to update overview page #28717
Conversation
|
As this is a dedicated page to updates, should we instead show them in a seperate card/section below it always? |
|
I like that idea 👍 it ensur s that they are always shown and are clearly noticeable as "manual installation needed" |
|
I've updated this PR so now we have to cards, one for installable and one for not installable updates Settings overview 
Settings > System > Updates
|
| "updates_refreshed": "State of {count} {count, plural,\n one {update}\n other {updates}\n} refreshed", | ||
| "checking_updates": "Checking for updates...", | ||
| "title": "{count} {count, plural,\n one {update}\n other {updates}\n}", | ||
| "title": "{count} {count, plural,\n one {{installable, select, \n true {installable} \n other {not installable}\n} update}\n other {{installable, select, \n true {installable} \n other {not installable}\n} updates}\n}", |
There was a problem hiding this comment.
This overcomplicates it IMO. Lets just leave the existing translation as is and add a new one for "not installable" updates.
The vast majority of cases will not have "not installable" updates so they don't need to see "installable" for normal updates. It would just confuse users and translators.
| </div> | ||
| </ha-card> | ||
| ` | ||
| : ""} |
There was a problem hiding this comment.
| : ""} | |
| : nothing} |
| </div> | ||
| </ha-card> | ||
| ` | ||
| : ""} |
There was a problem hiding this comment.
| : ""} | |
| : nothing} |
| ` | ||
| : ""} | ||
| ${canInstallUpdates.length + notInstallableUpdates.length | ||
| ? "" |
There was a problem hiding this comment.
| ? "" | |
| ? nothing |
| ? html` | ||
| ${canInstallUpdates.length | ||
| ? html` | ||
| <ha-card> |
There was a problem hiding this comment.
outlined is missing here. Is it intentional?
| const canInstallUpdates = this._filterUpdateEntitiesParameterized( | ||
| this.hass.states, | ||
| this._showSkipped | ||
| this._showSkipped, | ||
| false | ||
| ); | ||
| const notInstallableUpdates = this._filterUpdateEntitiesParameterized( | ||
| this.hass.states, | ||
| this._showSkipped, | ||
| true | ||
| ); |
There was a problem hiding this comment.
Calling _filterUpdateEntitiesParameterized twice with different args defeats the memoization as the cache only keeps the latest value.
You should create a new memoized method similar to _filterUpdateEntitiesParameterized for "not installable" updates instead of reusing _filterUpdateEntitiesParameterized.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
4 participants
Proposed change
This adds an option to also show not installable updates under Settings > System > Updates, so the user knows that there are systems, which needs attention and get updated manually.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: