Skip to content

Conversation

@mrand
Copy link
Contributor

@mrand mrand commented Jan 4, 2026

Proposed change

Add theme colors to toast provided by mwc-snackbar.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

I'm unclear if "warning" is the correct theme variable to use here, but it seemed close. Please feel free to adjust that, or anything else, as necessary, or I can.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

Copy link
Member

@MindFreeze MindFreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these are the correct variables for this

@mrand
Copy link
Contributor Author

mrand commented Jan 6, 2026

I don't think these are the correct variables for this

Thanks for the quick feedback, but if not these, than which?

@MindFreeze
Copy link
Member

MindFreeze commented Jan 6, 2026

Don't really know. We might need new ones. @wendevlin what do you think?

@wendevlin
Copy link
Member

Why is this PR changing the way it looks today? 🤔

I agree it should use ha theme colors, but look and feel should be the same as today in the default theme.

I don't think we have semantic colors that fits that. So we would need to add new ones.

Moreover the ha-toast element itself should add special component specific vars to fulfill the wish of the users.

e.g.: background-color: var(--ha-toast-background-color, var(--ha-color-on-surface-default)); so the theme designer can make specific definitions for toasts only.

@marcinbauer85 can you please jump in here and give us semantic colors to use for the toast messages?

@wendevlin wendevlin added the Needs UX Pull requests requiring a review from the Home Assistant design team label Jan 7, 2026
@marcinbauer85
Copy link
Member

Thanks for contributing, but the ha-toast needs to be migrated to Web Awesome, so adding new token variables to this now will cause theme issues at least twice for users - now and once it's migrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Needs UX Pull requests requiring a review from the Home Assistant design team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants