Standardize all energy period calculations #28827
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
We've got a couple different spots where we're trying to infer the energy period, and they sometimes have subtly different equations, so I'm not sure if it might be a bug if they come up with different result. Anyway we have a lot of magic number like "> 35" floating around and it's better to consolidate all that into a single standard function for calculating the period.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: