-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Allow wifi switches on mesh repeaters in AVM Fritz!Box Tools #36896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow wifi switches on mesh repeaters in AVM Fritz!Box Tools #36896
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe documentation for the AVM FRITZ!Box Tools integration has been updated to include a new section about WiFi switches. This section explains how WiFi switches are created for each SSID served by the FRITZ!Box, allowing users to activate or deactivate individual wireless networks. The documentation provides important details about WiFi switch behavior in mesh network setups, highlighting potential implications when disabling WiFi on mesh repeaters. Additionally, a new Changes
Sequence DiagramsequenceDiagram
participant User
participant FRITZ!Box
participant WiFi Switch
User->>WiFi Switch: Toggle SSID
WiFi Switch->>FRITZ!Box: Send enable/disable command
FRITZ!Box->>FRITZ!Box: Update SSID status
FRITZ!Box->>Mesh Repeaters: Propagate WiFi settings
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
source/_integrations/fritz.markdown (2)
105-115: LGTM! Consider reordering the warning for better visibility.The WiFi switches section provides clear and comprehensive information. However, consider moving the warning about mesh repeater connectivity before mentioning that the switches can be enabled. This would ensure users understand the risks before considering enabling these switches.
### WiFi switches WiFi {% term switches %} are created for each SSID the FRITZ!Box is serving. With these switches, one can activate and deactivate each single SSID. **Note 1**: In a mesh setup, the WiFi settings are adopted by each mesh repeater (_**Home Network > Mesh > Mesh Settings > Automatically Adopting Settings from the Mesh**_) -**Note 2**: For mesh repeaters, these switches are disabled by default, but can be enabled. - -{% important %} +{% important %} Please keep in mind, when your mesh is based on a WiFi connection between the mesh master and the mesh repeater, then disabling the WiFi on the repeater causes the repeater to become unavailable for Home Assistant. -{% endimportant %} +{% endimportant %} + +**Note 2**: For mesh repeaters, these switches are disabled by default, but can be enabled.
109-109: Consider adding a cross-reference to mesh configuration documentation.The note about mesh setup could benefit from a link to the mesh configuration documentation, similar to how you referenced it in the troubleshooting section.
-**Note 1**: In a mesh setup, the WiFi settings are adopted by each mesh repeater (_**Home Network > Mesh > Mesh Settings > Automatically Adopting Settings from the Mesh**_) +**Note 1**: In a [mesh](https://en.avm.de/service/knowledge-base/dok/FRITZ-Box-7590/3329_Mesh-with-FRITZ/) setup, the WiFi settings are adopted by each mesh repeater (_**Home Network > Mesh > Mesh Settings > Automatically Adopting Settings from the Mesh**_)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/fritz.markdown(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_integrations/fritz.markdown (1)
29-31: LGTM! Good addition of related documentation.The added cross-reference to entity management documentation is relevant and follows the correct documentation format.
Proposed change
SSIA
Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.Summary by CodeRabbit