Update Dockerfile #604
Open
Update Dockerfile #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove setuid for ping supporting older hosts (NAS) that don't have extended attributes.
There was a problem hiding this comment.
Pull Request Overview
Remove the setuid bit from the ping binary in the Docker image to avoid xattr errors on hosts lacking extended attribute support.
- Change
/bin/pingpermissions from4755to0755 - Rely on host networking for ICMP functionality
Comments suppressed due to low confidence (1)
Dockerfile:37
- There are no tests verifying that ping still functions without the setuid bit under host networking; consider adding an integration test to cover this use case.
&& chmod 0755 /bin/ping \
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove setuid for ping supporting older hosts (NAS) that don't have extended attributes.
♻️ Current situation
root@HomeNAS ~ # docker pull homebridge/homebridge:latest
latest: Pulling from homebridge/homebridge
0622fac788ed: Pull complete
70913027ecf4: Extracting [==================================================>] 223.5MB/223.5MB
06c8ff15a4f2: Download complete
726e97df8c02: Download complete
5555af05ef06: Download complete
63cccba96eec: Download complete
a99a466f3aad: Download complete
failed to register layer: lsetxattr security.capability /usr/bin/ping: operation not supported
💡 Proposed solution
Remove setuid, it's not required when the container has host networking.
⚙️ Release Notes
This is a bugfix and should have no impact
➕ Additional Information
If applicable, provide additional context in this section.
Testing
Which tests were added? Which existing tests were adapted/changed? Which situations are covered, and what edge cases are missing?
Reviewer Nudging
https://github.com/homebridge/docker-homebridge/blob/2025-05-16/Dockerfile#L37