fix: Homie framework fails with exception when compiled with sloeber #696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested by NodeMCU, Esp8266 V2.7.4, Sensor & Event demo. Signed-off-by: wang <[email protected]>
|
I think, we need to get the CI fixed. before merging more stuff. |
Signed-off-by: wang <[email protected]>
Signed-off-by: wang <[email protected]>
stritti
approved these changes
Dec 26, 2020
|
OK, I'll wait three more days for reviews to come in. If not, I'll merge the PR. |
|
Will have a look into this in the next days. But just understanding, what is going on, will take some hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested by NodeMCU, Esp8266 V2.7.4, Sensor & Event demo.
Signed-off-by: wang [email protected]