Default to most-recently-created tag #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion of the spec when a user clicks on the 'specification' tab
There was a problem hiding this comment.
Pull Request Overview
This PR updates the grabrepos.py script to default to the most recently created specification tag rather than the develop branch.
- The diff sorts repo tags by commit date in descending order instead of lexicographically.
- It changes the default file copied for the specification landing page to use the newest tag rather than "develop".
|
@jacoscaz : It works! Thanks a lot for this. I now get v4 spec when navigating to the homieiot page and select specification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the grabrepos.py script to default to the version of the specification tagged with the most-recently-created tag when a user clicks on the 'specification' tab.
I propose this change as I believe it would help with clarity and fostering the ecosystem around Homie. Once V5 will have been published, it would make more sense for first-time users to land on the current version of the spec rather than the development version as implementations should target the former.
Furthermore, this made for a good excuse to learn how to build the website locally.
EDIT: I hadn't noticed there was an issue for this! Closes #27 .