build: change the default AssetLoader type (#1247)

* build: change the default AssetLoader type to StreamingAssets * ci: set Local to AssetLoader Type when exporting packages
homuler · Aug 13, 2024 · ab78d5c · ab78d5c
1 parent e9b1fe4
commit ab78d5c
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 21 deletions.
diff --git a/.github/workflows/package.yml b/.github/workflows/package.yml
@@ -283,25 +283,7 @@ jobs:
         run: |
           rm MediaPipeUnityPlugin-all.zip
 
-      - name: Export tarball
-        run: |
-          cd Packages/com.github.homuler.mediapipe
-          npm pack
-          mv com.github.homuler.mediapipe-*.tgz ../..
-
-      - name: Upload the tarball package
-        uses: actions/upload-artifact@v4
-        with:
-          name: ${{ inputs.packageName }}-tarball
-          path: |
-            com.github.homuler.mediapipe-*.tgz
-          retention-days: 7
-
-      # avoid "No space left on device" error
-      - name: Remove uploaded files to free up space
-        run: |
-          rm com.github.homuler.mediapipe-*.tgz
-
+      # NOTE: this step will overwrite AppSettings.asset
       - name: Export unitypackage
         if: ${{ env.BUILD_UNITYPACKAGE == '1' }}
         run: |
@@ -316,6 +298,20 @@ jobs:
             *.unitypackage
           retention-days: 7
 
+      - name: Export tarball
+        run: |
+          cd Packages/com.github.homuler.mediapipe
+          npm pack
+          mv com.github.homuler.mediapipe-*.tgz ../..
+
+      - name: Upload the tarball package
+        uses: actions/upload-artifact@v4
+        with:
+          name: ${{ inputs.packageName }}-tarball
+          path: |
+            com.github.homuler.mediapipe-*.tgz
+          retention-days: 7
+
   clean:
     runs-on: ubuntu-latest
     needs:

diff --git a/Assets/MediaPipeUnity/Editor/PackageExporter.cs b/Assets/MediaPipeUnity/Editor/PackageExporter.cs
@@ -34,6 +34,9 @@ public static class PackageExporter
   [MenuItem("Tools/Export Unitypackage")]
   public static void Export()
   {
+    // Default Asset Loader Type is Local
+    OverwriteAssetLoaderType(Mediapipe.Unity.Sample.AppSettings.AssetLoaderType.Local);
+
     var packageRoot = Path.Combine(Application.dataPath, "..", "Packages", "com.github.homuler.mediapipe");
     var version = GetVersion(packageRoot);
 
@@ -101,6 +104,16 @@ private static string GetVersion(string packagePath)
     return version;
   }
 
+  private static void OverwriteAssetLoaderType(Mediapipe.Unity.Sample.AppSettings.AssetLoaderType assetLoaderType)
+  {
+    var appSettings = AssetDatabase.LoadAssetAtPath<Mediapipe.Unity.Sample.AppSettings>("Assets/MediaPipeUnity/Samples/Scenes/AppSettings.asset");
+    appSettings.assetLoaderType = assetLoaderType;
+
+    EditorUtility.SetDirty(appSettings);
+    AssetDatabase.SaveAssets();
+    AssetDatabase.Refresh();
+  }
+
   public class PackageJson
   {
     public string name;

diff --git a/Assets/MediaPipeUnity/Samples/Common/Scripts/AppSettings.cs b/Assets/MediaPipeUnity/Samples/Common/Scripts/AppSettings.cs
@@ -61,7 +61,11 @@ public enum AssetLoaderType
 
     public ImageSourceType defaultImageSource => _defaultImageSource;
     public InferenceMode preferableInferenceMode => _preferableInferenceMode;
-    public AssetLoaderType assetLoaderType => _assetLoaderType;
+    public AssetLoaderType assetLoaderType
+    {
+      get => _assetLoaderType;
+      set => _assetLoaderType = value;
+    }
     public Logger.LogLevel logLevel => _logLevel;
 
     public void ResetGlogFlags()

diff --git a/Assets/MediaPipeUnity/Samples/Scenes/AppSettings.asset b/Assets/MediaPipeUnity/Samples/Scenes/AppSettings.asset
@@ -14,7 +14,7 @@ MonoBehaviour:
   m_EditorClassIdentifier: 
   _defaultImageSource: 0
   _preferableInferenceMode: 0
-  _assetLoaderType: 2
+  _assetLoaderType: 0
   _logLevel: 5
   _glogMinloglevel: 0
   _glogStderrthreshold: 2