Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 3346 customized response messages #3362

Closed
wants to merge 4 commits into from
Closed

feat: 3346 customized response messages #3362

wants to merge 4 commits into from

Conversation

marceloverdijk
Copy link
Contributor

@marceloverdijk marceloverdijk commented Sep 2, 2024

As discussed with @yusukebe here https://github.com/orgs/honojs/discussions/3346

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.79%. Comparing base (bdaaa7f) to head (49ff3fc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3362      +/-   ##
==========================================
+ Coverage   95.76%   95.79%   +0.02%     
==========================================
  Files         151      151              
  Lines        9186     9250      +64     
  Branches     2708     2689      -19     
==========================================
+ Hits         8797     8861      +64     
  Misses        389      389              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusukebe yusukebe changed the title 3346 customized response messages feat: 3346 customized response messages Sep 3, 2024
@yusukebe
Copy link
Member

yusukebe commented Sep 3, 2024

Hi @marceloverdijk

Thank you for creating the PR. I have some requests:

  • I think the changes of src/context.ts and src/utils/mime.ts are not necessary in this feature. Please remove them.
  • Can you separate this PR for Basic Auth and Bearer Auth? This means you will close this PR and create new two PRs.

@marceloverdijk
Copy link
Contributor Author

No problem, I will update (and separate) the PR this evening.

@yusukebe
Copy link
Member

yusukebe commented Sep 3, 2024

@marceloverdijk

Thank you!

@yusukebe
Copy link
Member

yusukebe commented Sep 3, 2024

@marceloverdijk

Making strings as constant like APPLICATION_JSON_UTF_8 is good idea. But, it does not depends this feature and we can do it another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants