-
-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ws): Make WebSocket adapter more changeable #3531
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3531 +/- ##
==========================================
+ Coverage 94.30% 94.74% +0.44%
==========================================
Files 157 157
Lines 9488 9522 +34
Branches 2773 2801 +28
==========================================
+ Hits 8948 9022 +74
+ Misses 540 500 -40 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi @nakasyou Awesome! This is a good feature and refactors things, and the code is clean. I'll merge this now and include it into a patch release since this change does not introduce a new feature for the WebSocket feature for Bun/Deno/Workers adapters, which is facing the users. Thank you so much! |
* feat(ws): Make WebSocket adapter more changeable * lint * format code * test: add tests * format code * lint:fix * format code * test: add more tests
Closes #3468. And also related to #3005 and #3466.
In the PR, I added
defineWebSocketHelper
function andWSContext
class.We can change WebSocket helper interface easier than before merge this.
The author should do the following, if applicable
bun run format:fix && bun run lint:fix
to format the code