-
-
Notifications
You must be signed in to change notification settings - Fork 690
feat(cors): allowedMethods by function #4060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4060 +/- ##
==========================================
- Coverage 91.28% 91.27% -0.02%
==========================================
Files 168 168
Lines 10769 10779 +10
Branches 3029 3155 +126
==========================================
+ Hits 9831 9839 +8
- Misses 937 939 +2
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @Kanahiro
I think this is a good feature! I'll review the details later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi @Kanahiro I've reviewed this PR. It looks good. This is a new feature, but it's a slight change. So, I'm wondering which minor or patch release we should make. So, I'll decide and merge it later. Thanks! |
Sounds great! I've found and added a tiny improvement to remove one char |
The author should do the following, if applicable
bun run format:fix && bun run lint:fix
to format the codeProposal
In my usecase, it is needed to set different
Access-Control-Allow-Methods
by origins.Then, I modified
hono/cors
for 'allowedMethods' to acceptfunction
likeorigins
.How do you think?
Usecase
GET
orHEAD
can be performed from any origins, but others only from specific origin.