Skip to content

Conversation

@EdamAme-x
Copy link
Contributor

close: #4520

This PR fixes the incomplete work from the PR I created a year ago. (#3119)
I forgot to update the types for the input schemas such as $get and $post, and this mistake was caused by incorrect tests.
This PR should resolve everything. Sorry about that.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@EdamAme-x
Copy link
Contributor Author

Hi @NamesMT.
Can you review this?

@codecov
Copy link

codecov bot commented Nov 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.52%. Comparing base (4960c06) to head (206ef1d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4521   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files         172      172           
  Lines       11221    11221           
  Branches     3255     3255           
=======================================
  Hits        10270    10270           
  Misses        950      950           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NamesMT
Copy link
Contributor

NamesMT commented Nov 16, 2025

Hi @EdamAme-x
Change in this PR looks good to me, but I don't quite get why did #3120 added ParsedFormValue and T generic to ValidationTargets yet.
What will happen if we revert #3120 changes and simply just update FormValue to string | Blob and update the related tests if needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot use Blob for RPC form input

2 participants