Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deploy via GitHub Actions #477

Merged
merged 3 commits into from
Sep 10, 2024
Merged

feat: deploy via GitHub Actions #477

merged 3 commits into from
Sep 10, 2024

Conversation

yusukebe
Copy link
Member

Closes #473

Copy link

cloudflare-workers-and-pages bot commented Sep 10, 2024

Deploying hono with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5229da2
Status: ✅  Deploy successful!
Preview URL: https://84068f50.hono.pages.dev
Branch Preview URL: https://github-actions.hono.pages.dev

View logs

@yusukebe yusukebe merged commit d223aca into main Sep 10, 2024
2 checks passed
@yusukebe yusukebe deleted the github-actions branch September 10, 2024 06:27
@akku1139
Copy link
Contributor

Dear @yusukebe :

When I opened GitHub, I was surprised to see this Pull Request merged.
I think this is not good.

  1. Description is missing.
    Despite being a very important change, there is little explanation given.

  2. There is no reason to use yarn v1.
    Yarn v1 is under maintenance mode.
    Yarn v1 is no longer slower than npm.
    Yarn v4 is fast, but setting up v4 is not easy.
    Why was it bad to continue using pnpm?

  3. The execution event setting for Workflow looks incorrect.
    You need to add pull_request to on.
    https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request

You should revert this pull request.

@yusukebe yusukebe restored the github-actions branch September 16, 2024 09:22
@yusukebe yusukebe deleted the github-actions branch September 16, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable preview deployments for PRs
2 participants