Add messages to help with horizon-imp cli arg usage for #744 #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/imp/imp_main.cpp
Outdated
| } | ||
| else if (mode_board) { | ||
| expect_filename_arg(filenames, "board", 0); | ||
| expect_filename_arg(filenames, "planes", 1); |
Member
There was a problem hiding this comment.
The planes file is somewhat optional. If it's not there, it's not worth a warning that may confuse people.
Contributor
Author
There was a problem hiding this comment.
Thanks. It'll ignore the file exists check for that argument now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this is correct. Let me know if there's a better way to do it. I made it just give a warning instead of exit.