Do not ScopeObserver#scopeReferenceCounts when outlet is called before controller is connected #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e controller is connected
ildarkayumov
commented
May 25, 2024
| this.connectedContexts.add(context) | ||
| context.connect() | ||
|
|
||
| if (!this.connectedContexts.has(context)) { |
There was a problem hiding this comment.
we need this to prevent double controller#connect
|
I can confirm that this PR resolves the initially reported issue in #763 🎉 Thank you very much! |
|
@marcoroth can you check this please? |
|
Would be nice if this could be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #763
The problem occurs when Outlet is accessed before controller has been connected by Stimulus and somebody tries to disconnect such controller later.
in such case
ScopeObserver#elementMatchedValueis called 2 times sothis.scopeReferenceCountsis eq 2.and during
ScopeObserver#elementUnmatchedValuethis counterthis.scopeReferenceCountsremains >= 1 soscopeDisconnected(value)is not called