Accept symbol, proc, and nil arguments for broadcasts_refreshes #748
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
broadcasts_refreshes
only accepts values in the form of a string or nil, where explicitly passing nil bypasses broadcasting but still triggers theafter_create_commit
callback.This change allows you to pass a symbol (method name to call) or a proc to evaluate to
broadcasts_refreshes
to produce a stream name dynamically at the instance levelafter_create_commit
.This allows us to, for example, specify a parent (Board) to broadcast refreshes to on
create
, while broadcasting to itself (Column) onupdate
anddestroy
:Listen for new
Column
creations for@board
:Listen for updates and deletion of existing
@column
:This changes also disables the entire
after_create_commit
hook ifnil
is passed in explicitly, rather than allowing it to run without broadcasting anything.