BC-9973 - Migrate to Vitest #3761
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uidp
added
WIP
uidp
reviewed
Jun 20, 2025
| "types": ["node"], | ||
| "typeRoots": ["./node_modules/@types", "./types"], | ||
| "types": ["node", "vitest/globals"], | ||
| "typeRoots": ["./node_modules/@types", "./types", "./node_modules"], |
There was a problem hiding this comment.
We should avoid adding the whole node_modules path here.
uidp
reviewed
Jun 20, 2025
vite.config.ts
Outdated
| find: /^@@\/(.*)$/, | ||
| replacement: fileURLToPath(new URL("$1", import.meta.url)), | ||
| }, | ||
| ], |
There was a problem hiding this comment.
The additional resolve aliases are only used when running the tests. We should remove them from the configuration for build and serve commands.
odalys-dataport
commented
Jun 25, 2025
vite.config.ts
Outdated
| @@ -1,3 +1,4 @@ | |||
| /// <reference types="vitest" /> | |||
There was a problem hiding this comment.
What exactly is this for and is this still needed? As well as should we separate vite and vitest configs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Links to Ticket and related Pull-Requests
Changes
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging