Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enh/unit tests #97

Merged
merged 59 commits into from
Nov 17, 2023
Merged

Enh/unit tests #97

merged 59 commits into from
Nov 17, 2023

Conversation

greole
Copy link
Collaborator

@greole greole commented Nov 15, 2023

This PR adds unit tests for ldu to coo matrix conversion

greole and others added 30 commits October 23, 2023 14:44
@greole
fix issue when exporting csr/ell matrices
3116421
@greole
use regenerate for Ell for now
35864f9
@greole
use general ISAI
3c0458f
@greole
exclude IC for now
519b369
@greole
format files
5d062cc
@greole
Merge pull request #94 from hpsim/enh/extend-test
981f50a 
Add further tests
@greole
Remove environment variables (#95)
2522f49
@greole
base on sparse communicator branch
2b33020
@greole
adapt to new Ginkgo version
29bd1cb
@greole
Use localized_partition
169f87b
@greole
Fixup
f020611
@greole
construct sparse communicator
9451d53
@greole
reformat
b8fca33
@greole
reformat
c51a5e6
@greole
add a todo fixme notes check
42b1620
@greole
Allow - as separator
463199f
@greole
Allow - as separator
0111076
@greole
switch gko version to include try-run patch
e046396
@greole
add a todo fixme notes check
622e8da
@greole
add a todo fixme notes check
74c757c
@greole
add read_distributed with sparse comm
9c5732f 
- removed repartitioning for now
- moved sorted validation to python script (not implemented yet)
@greole
use local indices
c7f32c6
@greole
fixup
3a5a687
@greole
compute send_idxs
726420c
@greole
reorder header
d38eca9
@greole
move ctr to body
7949579
@greole
remove gko globalIndex
f840fe2
@greole
add stopping criterion
adabcfd
@greole
switch gko branch
ea10114
@greole
reformat
efa2a61
@greole greole requested a review from zbinkz November 15, 2023 10:02
zbinkz
zbinkz approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@zbinkz zbinkz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greole greole merged commit 33cc660 into refact/sparse_comm Nov 17, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbinkz zbinkz zbinkz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greole @zbinkz