Enable exact type checks with HPy_TypeCheck#309
Open
fangerer wants to merge 2 commits intohpyproject:masterfrom
Open
Enable exact type checks with HPy_TypeCheck#309fangerer wants to merge 2 commits intohpyproject:masterfrom
fangerer wants to merge 2 commits intohpyproject:masterfrom
Conversation
Contributor
|
Would it make sense to have |
Contributor
Author
|
Right, let's add inline helpers to improve readability. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CPython, there are usually macros like:
That translates to following in HPy:
As it turns out, the exact type check is pretty verbose in HPy and having two API calls may also be a high performance drawback.
An alternative approach would be to have a new API for that. Something like
HPy_TypeCheckExact(which would come with a new context function as well).