fix: insert-mode <Tab> inserts real tab when completion menu is not visible #2205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isible Problem: In Insert mode, pressing <Tab> with nvim-cmp mapped for completion could produce broken behavior: the first character of the word remains in place and extra spaces appear. This happens when the completion menu is not visible, because the fallback() function does not insert a real tab. Solution: - Added <Tab> mapping in the insert-mode preset (i and s modes). - If the completion menu is visible, <Tab> selects the next item as before. - If the menu is not visible, <Tab> inserts a real tab character, independent of expandtab, softtabstop, or other settings. - Command-line preset (<Tab> in c mode) keeps its previous behavior, now consistent with insert-mode. Impact: - Fixes the Insert-mode <Tab> bug for all users. - Maintains full compatibility with snippet plugins and completion navigation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
In Insert mode, pressing with nvim-cmp mapped for completion could
produce broken behavior: the first character of the word remains in place
and extra spaces appear. This happens when the completion menu is not
visible, because the fallback() function does not insert a real tab.
Solution:
of expandtab, softtabstop, or other settings.
consistent with insert-mode.
Impact: