Rework of sum2012's Half Skip readback mode

Core/Config.h

@@ -245,7 +245,7 @@ struct Config {
 	float fCwCheatScrollPosition;
 	float fGameListScrollPosition;
 	int iBloomHack; //0 = off, 1 = safe, 2 = balanced, 3 = aggressive
-	int iSkipGPUReadbackMode;  // 0 = off, 1 = skip, 2 = to texture
+	int iSkipGPUReadbackMode;  // 0 = off, 1 = skip, 2 = to texture, 3 = skip half
 	int iSplineBezierQuality; // 0 = low , 1 = Intermediate , 2 = High
 	bool bHardwareTessellation;
 	bool bShaderCache;  // Hidden ini-only setting, useful for debugging shader compile times.

Core/ConfigValues.h

@@ -188,6 +188,7 @@ enum class SkipGPUReadbackMode : int {
 	NO_SKIP,
 	SKIP,
 	COPY_TO_TEXTURE,
+	HALF_SKIP,
 };
 
 enum class RemoteISOShareType : int {

GPU/Common/FramebufferManagerCommon.cpp

@@ -1046,8 +1046,10 @@ void FramebufferManagerCommon::DownloadFramebufferOnSwitch(VirtualFramebuffer *v
 		// To support this, we save the first frame to memory when we have a safe w/h.
 		// Saving each frame would be slow.
 
-		// TODO: This type of download could be made async, for less stutter on framebuffer creation.
-		if (GetSkipGPUReadbackMode() == SkipGPUReadbackMode::NO_SKIP && !PSP_CoreParameter().compat.flags().DisableFirstFrameReadback) {
+		// TODO: This type of download could be made async, for less stutter on framebuffer creation.		
+
+		bool performReadback = ShouldReadback(&halfSkipDownloadFramebufferOnSwitch_);
+		if (performReadback) {
 			ReadFramebufferToMemory(vfb, 0, 0, vfb->safeWidth, vfb->safeHeight, RASTER_COLOR, Draw::ReadbackMode::BLOCK);
 			vfb->usageFlags = (vfb->usageFlags | FB_USAGE_DOWNLOAD | FB_USAGE_FIRST_FRAME_SAVED) & ~FB_USAGE_DOWNLOAD_CLEAR;
 			vfb->safeWidth = 0;
@@ -1061,12 +1063,31 @@ bool FramebufferManagerCommon::ShouldDownloadFramebufferColor(const VirtualFrame
 	return PSP_CoreParameter().compat.flags().Force04154000Download && vfb->fb_address == 0x04154000;
 }
 
+bool FramebufferManagerCommon::ShouldReadback(bool *toggle) {
+	bool performReadback = true;
+	switch (GetSkipGPUReadbackMode()) {
+	case SkipGPUReadbackMode::SKIP:
+		performReadback = false;
+		break;
+	case SkipGPUReadbackMode::HALF_SKIP:
+		*toggle = !*toggle;
+		performReadback = *toggle;
+		break;
+	case SkipGPUReadbackMode::COPY_TO_TEXTURE:
+	case SkipGPUReadbackMode::NO_SKIP:
+		break;
+	}
+	return performReadback;
+}
+
 bool FramebufferManagerCommon::ShouldDownloadFramebufferDepth(const VirtualFramebuffer *vfb) {
 	// Download depth buffer for Syphon Filter lens flares
-	if (!PSP_CoreParameter().compat.flags().ReadbackDepth || GetSkipGPUReadbackMode() != SkipGPUReadbackMode::NO_SKIP) {
+	if (!PSP_CoreParameter().compat.flags().ReadbackDepth) {
 		return false;
 	}
-	return (vfb->usageFlags & FB_USAGE_RENDER_DEPTH) != 0 && vfb->width >= 480 && vfb->height >= 272;
+
+	bool performDepthReadback = ShouldReadback(&halfSkipShouldDownloadFramebufferDepth_);
+	return performDepthReadback && (vfb->usageFlags & FB_USAGE_RENDER_DEPTH) != 0 && vfb->width >= 480 && vfb->height >= 272;
 }
 
 void FramebufferManagerCommon::NotifyRenderFramebufferSwitched(VirtualFramebuffer *prevVfb, VirtualFramebuffer *vfb, bool isClearingDepth) {
@@ -2173,9 +2194,10 @@ bool FramebufferManagerCommon::NotifyFramebufferCopy(u32 src, u32 dst, int size,
 		FlushBeforeCopy();
 		// TODO: In Hot Shots Golf, check if we can do a readback to a framebuffer here.
 		// Again we have the problem though that it's doing a lot of small copies here, one for each line.
+
 		if (srcH == 0 || srcY + srcH > srcBuffer->bufferHeight) {
 			WARN_LOG_ONCE(btdcpyheight, Log::FrameBuf, "Memcpy fbo download %08x -> %08x skipped, %d+%d is taller than %d", src, dst, srcY, srcH, srcBuffer->bufferHeight);
-		} else if (GetSkipGPUReadbackMode() == SkipGPUReadbackMode::NO_SKIP && (!srcBuffer->memoryUpdated || channel == RASTER_DEPTH)) {
+		} else if ((!srcBuffer->memoryUpdated || channel == RASTER_DEPTH) && ShouldReadback(&halfSkipDownloadFramebufferOnCopy_)) {
 			Draw::ReadbackMode readbackMode = Draw::ReadbackMode::BLOCK;
 			if (PSP_CoreParameter().compat.flags().AllowDelayedReadbacks) {
 				readbackMode = Draw::ReadbackMode::OLD_DATA_OK;

GPU/Common/FramebufferManagerCommon.h

@@ -521,7 +521,7 @@ class FramebufferManagerCommon {
 	void ResizeFramebufFBO(VirtualFramebuffer *vfb, int w, int h, bool force = false, bool skipCopy = false);
 
 	static bool ShouldDownloadFramebufferColor(const VirtualFramebuffer *vfb);
-	static bool ShouldDownloadFramebufferDepth(const VirtualFramebuffer *vfb);
+	bool ShouldDownloadFramebufferDepth(const VirtualFramebuffer *vfb);
 	void DownloadFramebufferOnSwitch(VirtualFramebuffer *vfb);
 
 	bool FindTransferFramebuffer(u32 basePtr, int stride, int x, int y, int w, int h, int bpp, bool destination, BlockTransferRect *rect);
@@ -649,6 +649,13 @@ class FramebufferManagerCommon {
 	// Depth readback helper state
 	u8 *convBuf_ = nullptr;
 	u32 convBufSize_ = 0;
+
+	// Half-skip toggles.
+	bool halfSkipDownloadFramebufferOnSwitch_ = false;
+	bool halfSkipDownloadFramebufferOnCopy_ = false;
+	bool halfSkipShouldDownloadFramebufferDepth_ = false;
+
+	bool ShouldReadback(bool *toggle);
 };
 
 // Should probably live elsewhere.

Tools/langtool/README.md

@@ -16,6 +16,11 @@ To see command line usage, type:
 cargo run -- --help
 ```
 
+Most common usage, to add a key:
+
+cargo run -- add-new-key Graphics "Skip half"
+
+
 To autoformat the code, use:
 
 ```bash

UI/GameSettingsScreen.cpp

@@ -441,7 +441,7 @@ void GameSettingsScreen::CreateGraphicsSettings(UI::ViewGroup *graphicsSettings)
 	CheckBox *disableCulling = graphicsSettings->Add(new CheckBox(&g_Config.bDisableRangeCulling, gr->T("Disable culling")));
 	disableCulling->SetDisabledPtr(&g_Config.bSoftwareRendering);
 
-	static const char *skipGpuReadbackModes[] = { "No (default)", "Skip", "Copy to texture" };
+	static const char *skipGpuReadbackModes[] = { "No (default)", "Skip", "Copy to texture" , "Skip half"};
 
 	PopupMultiChoice *skipGPUReadbacks = graphicsSettings->Add(new PopupMultiChoice(&g_Config.iSkipGPUReadbackMode, gr->T("Skip GPU Readbacks"), skipGpuReadbackModes, 0, ARRAY_SIZE(skipGpuReadbackModes), I18NCat::GRAPHICS, screenManager()));
 	skipGPUReadbacks->SetDisabledPtr(&g_Config.bSoftwareRendering);

assets/lang/ar_AE.ini

@@ -680,6 +680,7 @@ Screen Scaling Filter = ‎فلتر تكبير حجم الشاشة
 Show Debug Statistics = ‎أظهر معلومات التصحيح
 Show FPS Counter = ‎أظهر عداد الـFPS
 Skip GPU Readbacks = Skip GPU Readbacks
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = ‎تصيير السوفت وير (slow)
 Software Skinning = ‎طلاء برمجي

assets/lang/az_AZ.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = Screen scaling filter
 Show Debug Statistics = Show debug statistics
 Show FPS Counter = Show FPS counter
 Skip GPU Readbacks = Skip GPU Readbacks
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = Software rendering (experimental)
 Software Skinning = Software skinning

assets/lang/bg_BG.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = Screen scaling filter
 Show Debug Statistics = Покажи debug инфо
 Show FPS Counter = Покажи брояча за кадри в сек.
 Skip GPU Readbacks = Skip GPU Readbacks
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = Software rendering (експериментално)
 Software Skinning = Software skinning

assets/lang/ca_ES.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = Filtre d'escalat de pantalla
 Show Debug Statistics = Mostra estadístiques de depuració
 Show FPS Counter = Mostra comptador de FPS
 Skip GPU Readbacks = Saltar la lectura de GPU
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = Renderitzat per programari
 Software Skinning = "Skinning" per programari

assets/lang/cz_CZ.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = Filtr změny velikosti obrazovky
 Show Debug Statistics = Zobrazit statistiky ladění
 Show FPS Counter = Zobrazit počítadlo
 Skip GPU Readbacks = Skip GPU Readbacks
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = Softwarové vykreslování (experimentální)
 Software Skinning = Textury aplikuje software

assets/lang/da_DK.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = Skærmskaleringsfilter
 Show Debug Statistics = Vis debugstatistik
 Show FPS Counter = Vis FPS
 Skip GPU Readbacks = Skip GPU Readbacks
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = Software rendering (eksperiment)
 Software Skinning = Software skinning

assets/lang/de_DE.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = Filter für Bildskalierung
 Show Debug Statistics = Debugstatistiken anzeigen
 Show FPS Counter = FPS anzeigen
 Skip GPU Readbacks = Skip GPU Readbacks
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = Software Renderer (experimentell)
 Software Skinning = Software Skinning

assets/lang/dr_ID.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = Screen scaling filter
 Show Debug Statistics = Padenni Debugna
 Show FPS Counter = Padenni FPSna
 Skip GPU Readbacks = Skip GPU Readbacks
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = Pakeanni Software Tampilkan (dicoba-cobara)
 Software Skinning = Software skinning

assets/lang/en_US.ini

@@ -696,6 +696,7 @@ Screen Scaling Filter = Screen scaling filter
 Show Debug Statistics = Show debug statistics
 Show FPS Counter = Show FPS counter
 Skip GPU Readbacks = Skip GPU Readbacks
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = Software rendering (slow, accurate)
 Software Skinning = Software skinning

assets/lang/es_ES.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = Filtro de escalado de pantalla
 Show Debug Statistics = Mostrar estadísticas de depuración
 Show FPS Counter = Mostrar contador de FPS
 Skip GPU Readbacks = Saltar la lectura de GPU
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = Renderizado por software
 Software Skinning = "Skinning" por software

assets/lang/es_LA.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = Filtro de escalado de pantalla
 Show Debug Statistics = Mostrar estadísticas de depuración
 Show FPS Counter = Mostrar contador de FPS
 Skip GPU Readbacks = Skip GPU Readbacks
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = Renderizado por software (experimental)
 Software Skinning = Skineado por software

assets/lang/fa_IR.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = ‎فیلتر تغییر ساز صفحه
 Show Debug Statistics = ‎نمایش اطلاعات دیباگ
 Show FPS Counter = ‎نمایش شمارنده فریم بر ثانیه
 Skip GPU Readbacks = Skip GPU Readbacks
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = ‎(رندر نرم افزاری (آزمایشی
 Software Skinning = Software skinning

assets/lang/fi_FI.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = Näytön skaalauksen suodatin
 Show Debug Statistics = Näytä virheenkorjaustilastot
 Show FPS Counter = Näytä kuvalaskuri (FPS)
 Skip GPU Readbacks = Ohita GPU-lukemat
+Skip half = Skip half
 Smart 2D texture filtering = Älykäs 2D-tekstuurien suodatus
 Software Rendering = Ohjelmistopohjainen renderointi (kokeellinen)
 Software Skinning = Ohjelmistopohjainen muokkaus (skinning)

assets/lang/fr_FR.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = Filtre de mise à l'échelle de l'écran
 Show Debug Statistics = Montrer les statistiques de débogage
 Show FPS Counter = Montrer les compteurs
 Skip GPU Readbacks = Skip GPU Readbacks
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = Rendu logiciel (expérimental)
 Software Skinning = Enveloppe logicielle

assets/lang/gl_ES.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = Filtro de escalado de pantalla
 Show Debug Statistics = Mostrar estadísticas de depuración
 Show FPS Counter = Mostrar contador de FPS
 Skip GPU Readbacks = Skip GPU Readbacks
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = Renderizado por software (beta)
 Software Skinning = «Skinning» por software

assets/lang/gr_EL.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = Φίλτο κλιμάκωσης οθόνης
 Show Debug Statistics = Εμφάνιση στατιστικών αποσφαλμάτωσης
 Show FPS Counter = Εμφάνιση μετρητή FPS
 Skip GPU Readbacks = Skip GPU Readbacks
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = Απεικόνιση Λογισμικού (πειραματικό)
 Software Skinning = Εκδορά Λογισμικού

assets/lang/he_IL.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = Screen scaling filter
 Show Debug Statistics = הצג סטטיסטיקת באגים
 Show FPS Counter = הצג מונה
 Skip GPU Readbacks = Skip GPU Readbacks
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = עיבוד תוכנה (ניסיוני)
 Software Skinning = Software skinning

assets/lang/he_IL_invert.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = Screen scaling filter
 Show Debug Statistics = םיגאב תקיטסיטטס גצה
 Show FPS Counter = הנומ גצה
 Skip GPU Readbacks = Skip GPU Readbacks
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = )ינויסינ( הנכות דוביע
 Software Skinning = Software skinning

assets/lang/hr_HR.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = Mjerenje filtriranje zaslona
 Show Debug Statistics = Pokaži statistike otklanjanja grešaka
 Show FPS Counter = Pokaži FPS counter
 Skip GPU Readbacks = Skip GPU Readbacks
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = Žbukanje softvera (sporo)
 Software Skinning = Skiniranje softvera

assets/lang/hu_HU.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = Képernyő skálázási szűrő
 Show Debug Statistics = Hibakeresési statisztikák mutatása
 Show FPS Counter = FPS számláló mutatása
 Skip GPU Readbacks = Skip GPU Readbacks
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = Szoftveres renderelés (lassú)
 Software Skinning = Szoftveres "skinning"

assets/lang/id_ID.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = Pemfilteran penskala layar
 Show Debug Statistics = Tampilkan statistik awakutu
 Show FPS Counter = Tampilkan penghitung FPS
 Skip GPU Readbacks = Skip GPU Readbacks
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = Pelukisan perangkat lunak (eksperimental)
 Software Skinning = Pengkulitan perangkat lunak

assets/lang/it_IT.ini

@@ -673,6 +673,7 @@ Screen Scaling Filter = Filtro Scalatura Schermo
 Show Debug Statistics = Mostra Statistiche Debug
 Show FPS Counter = Mostra FPS
 Skip GPU Readbacks = Salta le letture della GPU
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = Rendering tramite Software (sperimentale)
 Software Skinning = Screpolatura software

assets/lang/ja_JP.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = 画像スケーリングのフィルタ
 Show Debug Statistics = デバッグ情報を表示する
 Show FPS Counter = FPSを表示する
 Skip GPU Readbacks = GPUリードバックのスキップ
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2Dテクスチャフィルタリング
 Software Rendering = ソフトウェアレンダリング (実験的)
 Software Skinning = ソフトウェアスキニング

assets/lang/jv_ID.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = Layar njongko Filter
 Show Debug Statistics = Tampilno statistik debug
 Show FPS Counter = Tampilno penghitung FPS
 Skip GPU Readbacks = Skip GPU Readbacks
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = Software rendering (jajalan)
 Software Skinning = Software skinning

assets/lang/ko_KR.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = 화면 크기 조정 필터
 Show Debug Statistics = 디버그 통계 표시
 Show FPS Counter = FPS 카운터 표시
 Skip GPU Readbacks = GPU 다시 읽기 건너뛰기
+Skip half = Skip half
 Smart 2D texture filtering = 스마트 2D 텍스처 필터링
 Software Rendering = 소프트웨어 렌더링 (느림)
 Software Skinning = 소프트웨어 스키닝

assets/lang/ku_SO.ini

@@ -686,6 +686,7 @@ Screen Scaling Filter = Screen scaling filter
 Show Debug Statistics = Show debug statistics
 Show FPS Counter = Show FPS counter
 Skip GPU Readbacks = Skip GPU Readbacks
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = Software rendering (slow, accurate)
 Software Skinning = Software skinning

assets/lang/lo_LA.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = ໂຕຕອງປັບສເກລໜ້າຈໍ
 Show Debug Statistics = ສະແດງຄ່າທາງສະຖິຕິການແກ້ໄຂຈຸດບົກພ່ອງ
 Show FPS Counter = ສະແດງຄ່າເຟຣມເຣດ ແລະ ຄວາມໄວ/ວິນາທີ
 Skip GPU Readbacks = Skip GPU Readbacks
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = ໃຊ້ຊອບແວຣ໌ສະແດງຜົນ (ລຸ້ນທົດລອງ)
 Software Skinning = ຊ໋ອບແວຣ໌ສກິນນິງ

assets/lang/lt-LT.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = Screen scaling filter
 Show Debug Statistics = Rodyti testinio režimo statistikas
 Show FPS Counter = Rodyti kadrų per sekundę rodmenis
 Skip GPU Readbacks = Skip GPU Readbacks
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = Programinės įrangos rodymas(ekspermentalus)
 Software Skinning = Programinės įrangos "nulupimas"

assets/lang/ms_MY.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = Screen scaling filter
 Show Debug Statistics = Papar statistik pepijat
 Show FPS Counter = Papar penghitung FPS
 Skip GPU Readbacks = Skip GPU Readbacks
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = Render perisian (eksperimen)
 Software Skinning = Pembalutan Perisian

assets/lang/nl_NL.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = Beeldschalingsfilter
 Show Debug Statistics = Foutopsporingsstatistieken weergeven
 Show FPS Counter = FPS-teller weergeven
 Skip GPU Readbacks = Skip GPU Readbacks
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = Renderen via software (experimenteel)
 Software Skinning = Skinning via software

assets/lang/no_NO.ini

@@ -672,6 +672,7 @@ Screen Scaling Filter = Screen scaling filter
 Show Debug Statistics = Vis debugstatistik
 Show FPS Counter = Vis FPS-teller
 Skip GPU Readbacks = Skip GPU Readbacks
+Skip half = Skip half
 Smart 2D texture filtering = Smart 2D texture filtering
 Software Rendering = Programvare gjengivelse (eksperiment)
 Software Skinning = Software skinning

assets/lang/pl_PL.ini

@@ -676,6 +676,7 @@ Screen Scaling Filter = Filtrowanie skalowania ekranu
 Show Debug Statistics = Pokaż statystyki debugowania
 Show FPS Counter = Pokaż licznik FPS
 Skip GPU Readbacks = Pomiń odczyty zwrotne GPU
+Skip half = Skip half
 Smart 2D texture filtering = Inteligentne filtrowanie tekstur 2D
 Software Rendering = Renderowanie programowe (wolne)
 Software Skinning = Programowy skinning

assets/lang/pt_BR.ini

@@ -696,6 +696,7 @@ Screen Scaling Filter = Filtro do dimensionamento da tela
 Show Debug Statistics = Mostrar estatísticas do debug
 Show FPS Counter = Mostrar contador dos FPS
 Skip GPU Readbacks = Ignorar leituras da GPU
+Skip half = Skip half
 Smart 2D texture filtering = Filtragem inteligente das texturas 2D
 Software Rendering = Renderização por software (lento)
 Software Skinning = Skinning via software