Надо подкачаться #12
Merged
Надо подкачаться #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
♻️ Я собрал ваш пулреквест. Посмотреть можно здесь. |
Spearance
reviewed
May 29, 2025
js/api.js
Outdated
| `${BASE_URL}/${endpoint[0] === '/' ? endpoint.slice(1) : endpoint}`; | ||
|
|
||
| const dataHandler = async (response) => { | ||
| if (response.status < 400) { |
There was a problem hiding this comment.
400 — магическое и должен быть 200
Spearance
reviewed
May 29, 2025
| .then((posts) => { | ||
| drawMiniatures(posts); | ||
| }) | ||
| .catch(() => {}); |
Spearance
reviewed
May 29, 2025
js/notification.js
Outdated
| const successTemplate = document.getElementById('success').content; | ||
|
|
||
| const showMessage = (template, config = {}) => { | ||
| const timeout = (config.timeout ?? 5) * 1000; |
|
♻️ Я собрал ваш пулреквест. Посмотреть можно здесь. |
|
♻️ Я собрал ваш пулреквест. Посмотреть можно здесь. |
|
♻️ Я собрал ваш пулреквест. Посмотреть можно здесь. |
|
♻️ Я собрал ваш пулреквест. Посмотреть можно здесь. |
|
♻️ Я собрал ваш пулреквест. Посмотреть можно здесь. |
Spearance
reviewed
Jun 2, 2025
|
|
||
| const isSuccess = (response) => { | ||
| // Статусы 200..299 считаем успешными (https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Status) | ||
| if (response.status >= 200 && response.status < 300) { |
There was a problem hiding this comment.
числа 200 и 300 считаются магическими, надо вынести в константы
|
|
||
| const isError = (response) => { | ||
| // 400 и далее - ошибка (всё та же спецификация) | ||
| if (response.status >= 400) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎓 Надо подкачаться
💥 https://htmlacademy-javascript.github.io/2586431-kekstagram-2/12/