feat(attr-sort): sort unknown attributes alphabetically #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedaviddias
approved these changes
Sep 17, 2021
This comment was marked as outdated.
This comment was marked as outdated.
stale
bot
added
the
bot:stale
thedaviddias
added
the
keep-unstale
|
Heya @chrisguttandin - can you please resolve the conflicts so we can get this one merged? Thanks! |
Previously unknown attributes were just ignored. Now they get sorted alphabetically. BREAKING CHANGE: HTMLHint will now throw an error if unkown attributes are not sorted. fix htmlhint#661
chrisguttandin
force-pushed
the
sort-all-attributes
branch
from
68423d7 to
1dc1b87
Compare
|
Hi @coliff, I've rebased the branch on top of the current master. |
|
@coliff Is there anything I can do about the failing CI tasks? |
|
Sorry for the delay - I think we need @thedaviddias for assistance on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously unknown attributes were just ignored. Now they get sorted alphabetically.
BREAKING CHANGE: HTMLHint will now throw an error if unkown attributes are not sorted.
fix #661
Short description of what this resolves:
This PR will make sure all attributes get sorted when using the attr-sorted rule. It will ensure that attributes linted with this rule will always get sorted the same way.
Please let me know if there is anything that should be changed to make this PR mergable.