Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Version of follow-redirects from 1.0.0 to 1.14.8 #1608

Closed
wants to merge 2 commits into from

Conversation

Annniee1
Copy link

@Annniee1 Annniee1 commented Sep 1, 2022

We are facing bugs in older version .Please Upgrade the version

We are facing bugs in older version .Please Upgrade the version
Please review the changes and update it
@Annniee1 Annniee1 changed the title Updated Version of follow-redirects , Updated Version of follow-redirects from 1.0.0 to 1.14.8 Sep 1, 2022
@Annniee1
Copy link
Author

Annniee1 commented Sep 2, 2022

@peters @darashi @benatkin @indexzero Please Review this Pull Request

@Annniee1
Copy link
Author

Hi @peters @darashi @benatkin @indexzero @Jimbly. Any Plan to merge this Pull Request?

@Jimbly
Copy link
Contributor

Jimbly commented Sep 13, 2022

I'm not a maintainer of this repo (as far as I know, it's dead), however I published http-proxy-node16 a while back, which is a fork of this repo that works on Node 16 without gigantic memory leaks (#1559). Feel free to send a PR over there and I'll publish it to NPM.

@Jimbly
Copy link
Contributor

Jimbly commented Sep 13, 2022

That being said, I believe follow-redirects v1.14.8 matches the semver specified here already, so I'm not sure this change is needed - if you install v1.14.8, it should use it, I think?

@Annniee1
Copy link
Author

That being said, I believe follow-redirects v1.14.8 matches the semver specified here already, so I'm not sure this change is needed - if you install v1.14.8, it should use it, I think?

Yaa @Jimbly . It matches the semver version specified. I am not sure why previously i was getting 1.14.7 and not 1.14.8.
But yes, it is working now.
Thanks!

@Annniee1 Annniee1 closed this Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants