Update async to ^3.2.6 #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterOdin
force-pushed
the
chore-async
branch
3 times, most recently
from
771b465 to
0e0a9c7
Compare
Member
|
Thanks for rebasing against the new jest branch(now in master). This looks good once those changes are in. |
Signed-off-by: Matthew Peveler <[email protected]>
Contributor
Author
|
Done @eriktrom. |
eriktrom
approved these changes
Mar 10, 2025
Member
eriktrom
left a comment
eriktrom
left a comment
There was a problem hiding this comment.
Nice work, thanks @MasterOdin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #153
PR updates async dependency to latest version. The only change that really affects this library was that the first function argument to
whilstnow has a callback function that need to call to return the test result, vs just returning it as before with v2.Per the discussion in the linked issue, need to drop support for Node <= 4 as async dropped support for those versions of node.