Skip to content

Conversation

@MasterOdin
Copy link
Contributor

@MasterOdin MasterOdin commented Mar 8, 2025

PR updates the library to use debug:^4.3.6 as dependency. This is the latest version (it's 2 behind), but I chose this version as it's the latest version that fixed JS deprecations or reported vulnerabilities, while still giving a bit of leeway to folks to dedupe if they already have a recentish version of debug installed.

There are no direct tests for debug, so I tested it by doing DEBUG=portfinder:* npm run test and confirming that the output remained the same between versions.

@eriktrom
Copy link
Member

Rebase and run npm install to re-lock, thanks!

@eriktrom
Copy link
Member

I chose this version as it's the latest version that fixed JS deprecations or reported vulnerabilities, while still giving a bit of leeway to folks to dedupe if they already have a recentish version of debug installed.

I agree

There are no direct tests for debug, so I tested it by doing DEBUG=portfinder:* npm run test and confirming that the output remained the same between versions.

Thanks for checking :)

Signed-off-by: Matthew Peveler <[email protected]>
@MasterOdin
Copy link
Contributor Author

@eriktrom rebased

@eriktrom
Copy link
Member

Gratzi!

@eriktrom eriktrom merged commit b64ab4f into http-party:master Mar 10, 2025
23 checks passed
@MasterOdin MasterOdin deleted the chore-debug branch March 11, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants