Bump version of jest #167
Bump version of jest #167
Conversation
|
|
||
| - name: Update npm | ||
| if: matrix.node-version == '6.x' | ||
| run: npm install -g npm@^5 |
There was a problem hiding this comment.
Should have been removed in #165, but missed it, whoops!
|
I will merge this and ship this after were done with the *Promise refactor, aka, once we implement getSocket with promise or callback - so that work is chunked in the commit line for easier understanding (by us years from now or someone else looking to learn the library) |
oh sweet - I literally pondered about this and you thought the same thing - thank you |
|
|
||
| - name: Install jest for node < 14 | ||
| if: matrix.node-version == '10.x' || matrix.node-version == '12.x' | ||
| run: npm install jest@^27.5.1 |
There was a problem hiding this comment.
Perfecto
Glad to have you around, I went through this all manually on my machine(s) as well but you're on top of it! very nice
|
so this had a conflict b/c we actually shipped 1.0.34 without mkdirp removed - rebase against mater again and it'll merge cleanly now |
Signed-off-by: Matthew Peveler <[email protected]>
|
@eriktrom Rebased.
My bad on not updating |
I wondered this same thing so I made a little app last night to and it would track the lockfile package.json - worth noting for knowledge sake and no worries, all good, not the end of the world, I should have caught it anyway |
2 participants
Closes #164
PR updates jest to the latest version. I setup the CI to install an old version of jest for node < 14 so that we can keep testing them. Since the test suite is pretty simple, and largely unchanging, I don't think this will pose much of a problem going forward, but if it does, easy to drop testing for node < 14.