getPort/getPorts return promise if no callback #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Peveler <[email protected]>
eriktrom
reviewed
Mar 12, 2025
| .catch(function (err) { | ||
| done(err); | ||
| }); | ||
| }); |
eriktrom
reviewed
Mar 12, 2025
| } | ||
| resolve(port); | ||
|
|
||
| if (!callback) { |
Member
|
One of my favorite PRs ever. So clean. One API. Thank you!
Yeah - I mean - we just don't ever need to remove the aliases, given the code to keep them is a one liner and not subject to maintenance issues - and yeah the same idea applies to |
Member
|
closes #166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #166
PR makes it so that calling the
getPortorgetPortsmethod without providing a callback will have them return a promise instead. This makes the library more similar to others that support both a callback and a promise interface, without needing extra functions.The
getPortPromiseandgetPortsPromisemethods are retained for backwards compatibility, but may wish to mark them as deprecated via jsdoc so that people move to usinggetPortandgetPorts.