if startPort is provided by user, actually use it
#177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriktrom
force-pushed
the
fix-start-port-external-api
branch
from
82ac30c to
65274a6
Compare
eriktrom
commented
Mar 14, 2025
| ])(`the %s method (promise: %p)`, function (name, isPromise, method) { | ||
| test('with startPort less than or equal to 80', function (done) { | ||
| if (isPromise) { | ||
| method({ startPort: 80 }) |
Member
Author
There was a problem hiding this comment.
so we had this test which was hiding the fact that startPort didn't even work - we thought we set it to port 80 and then tested it went higher but it was the basePort that was making it do that - now its correct
Member
Author
|
@MasterOdin - review me :) |
MasterOdin
approved these changes
Mar 14, 2025
Use beforeAll/afterAll w/o done callback in test setup/teardown per pr review feedback Co-authored-by: Matthew Peveler <[email protected]>
eriktrom
force-pushed
the
fix-start-port-external-api
branch
from
989caf4 to
8523a9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #173