Fix flaky test in ScalaXmlSuite by properly handling XML special characters #214
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #88 - Flaky test in ScalaXmlSuite
Explanation
While investigating the flaky test behavior in
ScalaXmlSuite
, I found that thegenText
function ingenerators.scala
wasn't handling XML special characters according to the XML 1.0 specification. This led to abnormal test behavior when special characters like "&" and "<" were present in the generated text.Proposed Solution
The fix involves proper XML character escaping in the
genText
function:Gen[Text]
return type for compatibilityThis change ensures that:
Testing
The changes have been tested to ensure:
Questions for Review
I am eager to get feedback on:
Thank you for taking the time to review this PR