Fix #1614: Replace assertion with proper error handling in argument parser #1666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ns-fboucault
force-pushed
the
fix/issue-1614-assertion-error
branch
from
a3d4bf0 to
3203e22
Compare
…ment parser Replace bare `assert` statement in `_guess_method()` with proper error handling to prevent AssertionError from being exposed to users. The assertion `assert not self.args.request_items` at line 416 could fail in edge cases, causing users to see an unhelpful stack trace instead of a clear error message. Changes: - httpie/cli/argparser.py: Replace assertion with self.error() call - tests/test_cli.py: Add 2 regression tests to TestArgumentParser class Fixes httpie#1614
ns-fboucault
force-pushed
the
fix/issue-1614-assertion-error
branch
from
3203e22 to
48c169a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces a bare
assertstatement in the argument parser with proper error handling to preventAssertionErrorfrom being exposed to users.Problem
The
_guess_method()function had an assertion that could fail in edge cases:When this fails, users see an unhelpful stack trace instead of a clear error message.
Solution
Replace the assertion with user-facing error handling:
Changes
httpie/cli/argparser.py: Replace assertion withself.error()calltests/test_cli.py: Add 2 regression tests toTestArgumentParserclassTesting
All tests pass. Backward compatible - no changes to valid command behavior.
Fixes #1614