fix(https): add option to disable TLS 1.0 cxns #189
Merged
+95
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
|
pimterry
requested changes
Mar 17, 2025
test/integration/https.spec.ts
Outdated
|
|
||
| describe.only("with TLS version restrictions", () => { |
There was a problem hiding this comment.
This shouldn't be .only, or it'll disable all the other tests!
There was a problem hiding this comment.
nice catch! artefact from my feedback loop of implementing this
| minVersion: 'TLSv1.2' | ||
| } | ||
| } |
There was a problem hiding this comment.
Indentation has gone all funky here
There was a problem hiding this comment.
have another look? if not happy, would you let me know how you lint the project? i was expecting to find a lint script to run npm run lint.
pimterry
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #187