Add foe traffic signals to observation signals. #1714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gamenot
requested review from
Adaickalavan,
qianyi-sun and
saulfield
and removed request for
saulfield
Gamenot
requested review from
Adaickalavan,
qianyi-sun and
saulfield
and removed request for
Adaickalavan,
qianyi-sun and
saulfield
Gamenot
force-pushed
the
tucker/add-intersection_signals
branch
from
710152a to
c225cae
Compare
saulfield
approved these changes
Jan 4, 2023
Adaickalavan
approved these changes
Jan 5, 2023
Adaickalavan
reviewed
Jan 5, 2023
smarts/core/sensors.py
Outdated
Comment on lines
1307
to
1318
| if self._include_foes: | ||
| self._find_foe_signals(lane, used_features, upcoming_signals) | ||
|
|
||
| lookahead = self._lookahead - lane.length + lane_pos.s | ||
| self._find_signals_ahead(lane, lookahead, plan.route, upcoming_signals) | ||
| self._find_signals_ahead( | ||
| lane, | ||
| lookahead, | ||
| plan.route, | ||
| self._include_foes, | ||
| used_features, | ||
| upcoming_signals, | ||
| ) |
Member
There was a problem hiding this comment.
It would be better to have functions with return values, compared to relying on functions with side effects.
Gamenot
force-pushed
the
tucker/add-intersection_signals
branch
2 times, most recently
from
7e5c491 to
a5d0ff9
Compare
Gamenot
force-pushed
the
tucker/add-intersection_signals
branch
from
a5d0ff9 to
ef8ef50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is intended to expose foe traffic signals through
AgentInterfaceconfiguration.