-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update examples #2079
Update examples #2079
Conversation
The end understanding is that this will be implemented for experiments |
01b8c40
to
bac6609
Compare
bac6609
to
8b0aca8
Compare
examples = | ||
hydra-core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update list of examples and instructions at SMARTS/docs
and SMARTS/README.md
files.
examples/tools/primitive_agents.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move and merge these agents to SMARTS/zoo/policies
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found importing SMARTS/zoo
to be slightly complicated but it might be most reasonable to do that, leaving one local example to show how it works. Although, I am actually not sure how useful these primitives are generally, I would also like to have ML agents available for the base experiments.
Do we have any readily available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am planning to create one scl-zoo-installable ML zoo agent by simply creating a packaged agent from trained examples/RL/drive/inference
code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I think that should go into this PR. Or into a mandatory follow-up.
f7f4b8d
to
b1e5f5a
Compare
0d19e83
to
95e90f5
Compare
990054a
to
35bafda
Compare
This example can be run like this:
I think this might require some experiment engineering but I have set up the basics for creating an experiment.