Derek furst/validate direct ancestors #964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly datasets, publications, and samples. Organ samples not allowed
…th the existing one to return superclasses. Reworked validator to do all validation inside a single neo4j query rather than iteating through a python loop.
yuanzhou
reviewed
Nov 24, 2025
src/schema/schema_validators.py
Outdated
| from schema import schema_neo4j_queries | ||
| from schema.schema_constants import SchemaConstants | ||
| from hubmap_commons import hm_auth | ||
| from app_neo4j_queries import get_entities_by_uuid |
Member
There was a problem hiding this comment.
@DerekFurstPitt Do we still need this import with your new implementation?
Contributor
Author
There was a problem hiding this comment.
@yuanzhou No we don't, good catch. Just pushed an update
yuanzhou
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a new validator to check whether dataset direct ancestors are only datasets, publications, and samples. Organ samples not allowed