Skip to content

fix(plugin-flow-builder): add is meaningful node tracking #874 #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vanbasten17 merged 2 commits into from
Jun 13, 2024
Merged

fix(plugin-flow-builder): add is meaningful node tracking #874 #2852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab99cc9
fix(plugin-flow-builder): add is meaningful node tracking
vanbasten17 Jun 13, 2024
69f7356
fix(plugin-flow-builder): is_meaningful should be optional
vanbasten17 Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/botonic-plugin-flow-builder/src/content-fields/hubtype-fields/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ export interface HtBaseNode {
follow_up?: HtNodeLink
target?: HtNodeLink
flow_id: string // TODO: Review if this field is necessary in all HtBaseNode
is_meaningful?: boolean
}

export interface HtTextLocale {
Expand Down
4 changes: 3 additions & 1 deletion packages/botonic-plugin-flow-builder/src/tracking.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export async function trackFlowContent(
flowId: firstNodeContent.flow_id,
flowName,
id: firstNodeContent.id,
isMeaningful: firstNodeContent.is_meaningful ?? false,
})
await trackEvent(request, EventAction.FlowNode, eventArgs)
}
Expand All @@ -54,6 +55,7 @@ export function getContentEventArgs(
flowId: string
flowName: string
id: string
isMeaningful: boolean
}
) {
const flowBuilderPlugin = getFlowBuilderPlugin(request.plugins)
Expand All @@ -63,6 +65,6 @@ export function getContentEventArgs(
flowName: flowBuilderPlugin.getFlowName(contentInfo.flowId),
flowNodeId: contentInfo.id,
flowNodeContentId: contentInfo.code,
flowNodeIsMeaningful: undefined, //node?.isMeaningful,
flowNodeIsMeaningful: contentInfo.isMeaningful,
}
}