[NCN-619] fix adding students to course sections

hubzero · Nov 6, 2023 · 0cbf408 · 0cbf408
1 parent 2acd287
commit 0cbf408
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/core/components/com_courses/admin/assets/js/courses.js b/core/components/com_courses/admin/assets/js/courses.js
@@ -59,7 +59,7 @@ jQuery(document).ready(function($){
 		$("#btn-generate").on('click', function(e){
 			Hubzero.submitbutton('generate');
 
-			window.top.setTimeout("window.parent.location=" + $(this).attr('data-redirect'), 700);
+			window.top.setTimeout("window.parent.location='" + $(this).attr('data-redirect') + "'", 700);
 		});
 
 		$("#btn-attach").on('click', function(e){
@@ -126,8 +126,8 @@ jQuery(document).ready(function($){
 		offering_id.on('change', function(e){
 			changeDynaList(
 				'section_id',
-				offeringsections,
-				document.getElementById('offering_id').options[document.getElementById('offering_id').selectedIndex].value
+				offeringsections['data'],
+				document.getElementById('offering_id').options[document.getElementById('offering_id').selectedIndex].value,
 				0,
 				0
 			);

diff --git a/core/components/com_courses/admin/views/codes/tmpl/options.php b/core/components/com_courses/admin/views/codes/tmpl/options.php
@@ -21,8 +21,9 @@
 }
 
 Html::behavior('framework', true);
+Html::behavior('formvalidation', true);
 
-$this->js();
+$this->js()->js('timepicker.js');
 
 $offset = Config::get('config.offset');
 

diff --git a/core/components/com_courses/admin/views/students/tmpl/add.php b/core/components/com_courses/admin/views/students/tmpl/add.php
@@ -99,7 +99,7 @@
 										$data[$j++] = array($offering->get('id'), $section->get('id'), $section->get('title'));
 									}
 									?>
-									<option value="<?php echo $this->escape(stripslashes($offering->get('id'))); ?>"<?php if ($offering->get('id') == $this->row->get('offering_id')) { echo ' selected="selected"'; } ?>><?php echo $this->escape(stripslashes($offering->get('alias'))); ?></option>
+									<option value="<?php echo $this->escape(stripslashes($offering->get('id'))); ?>"<?php if ($offering->get('id') == $this->offering->get('id')) { echo ' selected="selected"'; } ?>><?php echo $this->escape(stripslashes($offering->get('alias'))); ?></option>
 									<?php
 								}
 								?>
-Original file line number
+Diff line change
@@ Expand Up / @@ -99,7 +99,7 @@ @@
     										$data[$j++] = array($offering->get('id'), $section->get('id'), $section->get('title'));
     									}
     									?>
-    									<option value="<?php echo $this->escape(stripslashes($offering->get('id'))); ?>"<?php if ($offering->get('id') == $this->row->get('offering_id')) { echo ' selected="selected"'; } ?>><?php echo $this->escape(stripslashes($offering->get('alias'))); ?></option>
+    									<option value="<?php echo $this->escape(stripslashes($offering->get('id'))); ?>"<?php if ($offering->get('id') == $this->offering->get('id')) { echo ' selected="selected"'; } ?>><?php echo $this->escape(stripslashes($offering->get('alias'))); ?></option>
     									<?php
     								}
     								?>
@@ Expand Down @@