move setQuery into check if query exists

hubzero · Feb 7, 2025 · 887bcd3 · 887bcd3
1 parent 94f2e41
commit 887bcd3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/core/components/com_tools/models/tool.php b/core/components/com_tools/models/tool.php
@@ -503,10 +503,10 @@ public function _sql_update($all = false)
 			$query = '';
 		}
 
-		$db->setQuery($query);
-
 		if (!empty($query))
 		{
+			$db->setQuery($query);
+
 			$result = $db->query();
 
 			if ($result === false)
@@ -1608,7 +1608,7 @@ public static function validate(&$tool, &$err, $id)
 			}
 		}
 
-		if (count($err) > 0)
+		if (is_array($err) && count($err) > 0)
 		{
 			return false;
 		}

diff --git a/core/components/com_tools/models/version.php b/core/components/com_tools/models/version.php
@@ -684,7 +684,6 @@ private function _sql_update($all = false)
 	{
 		$db = \App::get('db');
 
-		Log::debug('_sql_update() start');
 		$query = "UPDATE #__tool_version SET ";
 
 		$classvars = get_class_vars(__CLASS__);
@@ -693,6 +692,7 @@ private function _sql_update($all = false)
 
 		foreach ($classvars as $property => $value)
 		{
+
 			if (($property[0] == '_') || in_array($property, $this->_list_keys))
 			{
 				continue;
@@ -731,10 +731,10 @@ private function _sql_update($all = false)
 			$query = '';
 		}
 
-		$db->setQuery($query);
-
 		if (!empty($query))
 		{
+			$db->setQuery($query);
+
 			$result = $db->query();
 
 			if ($result === false)