Add sorting exceptions for logical property shorthands #162
Conversation
hudochenkov
left a comment
hudochenkov
left a comment
There was a problem hiding this comment.
We are very happy users of your plugin at the nl-design-system project
Wow, this is awesome! Thank you for sharing this :)
Could you add tests, please, so we would be confident things won't break in future? Few accept tests, where order is correct. And few reject tests, where order is incorrect.
For autofixing working correctly we would need to update postcss-sorting package also, because it powers autofixing.
| 'margin-block', | ||
| 'margin-block-end', | ||
| 'margin-block-start', | ||
| 'margin-inline', | ||
| 'margin-inline-end', | ||
| 'margin-inline-start', |
There was a problem hiding this comment.
Is it needed to duplicate properties here, since they have separate declarations below?
There was a problem hiding this comment.
Yes, will do that. Might not have time for the tweaks until Monday, but I won't forget about it.
There was a problem hiding this comment.
And I will write tests and find out if they are necessary.
|
Fixed in 8a28522 and released in |
2 participants
Hi Aleks, thanks for your work on stylelint! We are very happy users of your plugin at the nl-design-system project 😃
We ran into some issues where
borderwould overwrite the logical properties such asborder-block-end-color, so I thought to update the shorthands data with all the new logical CSS properties I could find on MDN.