Skip to content

Adds a multiply_grads akin to fairseq #3185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

muellerzr
Copy link
Contributor

What does this PR do?

Helps w/ DDP wrt huggingface/transformers#34283

fairseq came up with a technique to help also with countering gradient accumulation by countering grad update by multiplying the gradients by num_gpus / num_items_in_batch. This PR adds an interface for the Trainer to hook into.

Without it:

W B Chart 10_22_2024, 12_30_21 PM

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@SunMarc

@muellerzr muellerzr requested a review from SunMarc October 22, 2024 16:31
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! It would be also nice to compare if it is better to update the optimizer or the loss directly in transformers.

@muellerzr
Copy link
Contributor Author

I found in general both were needed.

@sbwww
Copy link

sbwww commented Oct 23, 2024

There is a minor concern, would this fix be suitable for all backends (PyTorch DDP/FDSP, DeepSpeed, Megatron)?

I notice that DeepSpeed optimizer has unique groups (bf16_groups and fp32_groups_gradients) in its wrapped optimizer. And, grads in bf16_groups are accumulated into fp32_groups_gradients and deallocated in each backward call, .

I'm not sure whether param_groups in accelerator is a wrap of bf16_groups or fp32_groups_gradients in DeepSpeed? Previously I had an attempt to manipulate grads in optimizer. However, grads in optimizer are all 0 after backward when I use accelerate + DeepSpeed.

So, I'm afraid multiply_grads would not work for current DeepSpeed integration.


DeepSpeed/deepspeed/runtime/bf16_optimizer.py :

https://github.com/microsoft/DeepSpeed/blob/b647fb2470f8f6fefe5cab0ea84a2d89696eb898/deepspeed/runtime/bf16_optimizer.py#L316-L329

@muellerzr muellerzr closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants